This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Updating profiler tutorial to include new custom operator profiling #15403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aaronmarkham - Can you please help review. Thanks. |
aaronmarkham
suggested changes
Jun 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some spelling and rephrasing...
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Co-Authored-By: Aaron Markham <[email protected]>
Thanks! I have committed all the suggested changes. |
aaronmarkham
approved these changes
Jun 29, 2019
sandeep-krishnamurthy
suggested changes
Jun 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Few comments.
change image url to dmlc and add a code example
OK, I can add another code snippet and make sure we have this line: |
sandeep-krishnamurthy
approved these changes
Jul 2, 2019
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 6, 2019
…filing (apache#15403)" This reverts commit d49445f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the profiler tutorial to include a new section on profiling custom operators.
This is a reflection on my work here: #15210
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments